gjacoby126 commented on a change in pull request #935:
URL: https://github.com/apache/phoenix/pull/935#discussion_r522549122
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/DropColumnMutator.java
##########
@@ -268,7 +272,19 @@ public MetaDataMutationResult
validateAndAddMetadata(PTable table,
}
}
- tableMetaData.addAll(additionalTableMetaData);
+ if (isDroppingColumns) {
Review comment:
It's not really general-purpose enough to put in a standalone Util
method in MetaDataUtil, and since it's only 3 lines repeated in 2 places I
figured the minor violation of DRY (Don't Repeat Yourself) wasn't worth working
around, since all alternatives I could think of seemed a little ugly.
For example, I could put a static utility method in one of the mutators, but
then one depends on the other which couples classes that shouldn't be...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
