gjacoby126 commented on a change in pull request #935:
URL: https://github.com/apache/phoenix/pull/935#discussion_r527047479
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java
##########
@@ -387,6 +388,48 @@ public void testViewUsesTableLocalIndex() throws Exception
{
}
}
+ @Test
+ public void testCreateViewTimestamp() throws Exception {
+ String tenantId = null;
+ createViewTimestampHelper(tenantId);
Review comment:
I could just pass null, but this seemed more self-documenting (because
the name makes it clear that I'm passing a null tenant id, rather than making
someone need to look at the function def to figure that out)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
