gjacoby126 commented on a change in pull request #935:
URL: https://github.com/apache/phoenix/pull/935#discussion_r525588559
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
##########
@@ -2846,21 +2872,25 @@ private MetaDataMutationResult mutateColumn(
separateLocalAndRemoteMutations(region, tableMetadata,
localMutations,
remoteMutations);
if (!remoteMutations.isEmpty()) {
- // there should only be remote mutations if we are adding
a column to a view
+ // there should only be remote mutations if we are
updating the last ddl
+ // timestamp for child views, or we are adding a column to
a view
// that uses encoded column qualifiers (the remote
mutations are to update the
// encoded column qualifier counter on the parent table)
- if (mutator.getMutateColumnType() ==
ColumnMutator.MutateColumnType.ADD_COLUMN
+ if (childViews.size() > 0 || (
mutator.getMutateColumnType() == ColumnMutator.MutateColumnType.ADD_COLUMN
Review comment:
I added the childViews.size() check when I was sending the ddl timestamp
mutations remotely to the child view header rows, which I stopped doing in the
last draft. That part of the if clause should just be removed right? Or was the
existing logic wrong if a child view existed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
