[
https://issues.apache.org/jira/browse/PHOENIX-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245519#comment-17245519
]
ASF GitHub Bot commented on PHOENIX-6200:
-----------------------------------------
tkhurana commented on a change in pull request #995:
URL: https://github.com/apache/phoenix/pull/995#discussion_r537816314
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRepairRegionScanner.java
##########
@@ -178,6 +183,28 @@ protected void repairIndexRows(Map<byte[], List<Mutation>>
indexMutationMap,
return actualIndexMutationMap;
}
+ private Map<byte[], List<Mutation>> populateActualIndexMutationMap()
throws IOException {
+ Map<byte[], List<Mutation>> actualIndexMutationMap =
Maps.newTreeMap(Bytes.BYTES_COMPARATOR);
+ Scan indexScan = new Scan();
+ indexScan.setTimeRange(scan.getTimeRange().getMin(),
scan.getTimeRange().getMax());
+ indexScan.setRaw(true);
+ indexScan.setMaxVersions();
+ indexScan.setCacheBlocks(false);
+ try (RegionScanner regionScanner = region.getScanner(indexScan)) {
Review comment:
@gokceni hasMore will be false in that case and the code should exit
the loop. This is a standard pattern used in multiple places in the index
rebuild code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add counters for extra index rows, log results to PIT and PIT_RESULT table
> --------------------------------------------------------------------------
>
> Key: PHOENIX-6200
> URL: https://issues.apache.org/jira/browse/PHOENIX-6200
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Tanuj Khurana
> Assignee: Tanuj Khurana
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
