[ 
https://issues.apache.org/jira/browse/PHOENIX-6249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245928#comment-17245928
 ] 

ASF GitHub Bot commented on PHOENIX-6249:
-----------------------------------------

stoty commented on pull request #43:
URL: https://github.com/apache/phoenix-connectors/pull/43#issuecomment-740664747


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m  7s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   8m  0s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  12m 37s |  master passed  |
   | +1 :green_heart: |  compile  |   2m 31s |  master passed  |
   | +1 :green_heart: |  javadoc  |   1m 57s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 22s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  19m 50s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 32s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 32s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  xml  |   0m 10s |  The patch has no ill-formed XML 
file.  |
   | +1 :green_heart: |  javadoc  |   1m 53s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |  17m 26s |  root in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 45s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  69m 58s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-43/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/phoenix-connectors/pull/43 |
   | Optional Tests | dupname asflicense javac javadoc unit xml compile |
   | uname | Linux d8e34d3a18b2 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-connectors-personality.sh |
   | git revision | master / 38bcd9a |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | unit | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-43/1/artifact/yetus-general-check/output/patch-unit-root.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-43/1/testReport/
 |
   | Max. process+thread count | 1671 (vs. ulimit of 30000) |
   | modules | C: phoenix-spark-base phoenix-spark-base/phoenix4-spark 
phoenix-spark-base/phoenix5-spark phoenix4-connectors-assembly 
phoenix5-connectors-assembly . U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-43/1/console
 |
   | versions | git=2.7.4 maven=3.3.9 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Create shaded phoenix-spark connector jar
> -----------------------------------------
>
>                 Key: PHOENIX-6249
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6249
>             Project: Phoenix
>          Issue Type: Task
>          Components: connectors, spark-connector
>    Affects Versions: connectors-6.0.0
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>
> Since connectors have been split, we do not have the spark connector shaded 
> into phoenix-client.
> Create shaded connector for spark that takes Hadoop from the spark classpath 
> (thus minimizing the chances of classpath conflicts)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to