[
https://issues.apache.org/jira/browse/PHOENIX-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258264#comment-17258264
]
ASF GitHub Bot commented on PHOENIX-6296:
-----------------------------------------
gjacoby126 commented on a change in pull request #1055:
URL: https://github.com/apache/phoenix/pull/1055#discussion_r551367729
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/RowValueConstructorOffsetIT.java
##########
@@ -76,7 +76,7 @@
private static Connection conn = null;
@BeforeClass
- public static void init() throws SQLException {
+ public static synchornized void init() throws SQLException {
Review comment:
typo here (syncronized misspelled) : curious how this is compiling?
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIndexIdRetrieveIT.java
##########
@@ -62,7 +62,7 @@
" FROM SYSTEM.CATALOG WHERE TABLE_NAME='%s' AND COLUMN_COUNT IS
NOT NULL";
@BeforeClass
- public static void setUp() throws Exception {
+ public static snychronized void setUp() throws Exception {
Review comment:
typo here: shouldn't compile
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Synchronize @Parameters, @BeforeClass and @AfterClass methods take 2
> --------------------------------------------------------------------
>
> Key: PHOENIX-6296
> URL: https://issues.apache.org/jira/browse/PHOENIX-6296
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Affects Versions: 5.1.0, 4.16.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Critical
>
> The work done for PHOENIX-5554 has been undone, we have a lot of
> unsynchronized methods again.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
