virajjasani commented on a change in pull request #1096:
URL: https://github.com/apache/phoenix/pull/1096#discussion_r559502069
##########
File path: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
##########
@@ -2006,4 +2007,17 @@ public void run() {
thread.setDaemon(true);
thread.start();
}
+
+ /**
+ * Confirms that no storeFile has refCount leakage
+ *
+ * @throws IOException if refCount is leaked
+ */
+ protected synchronized static void confirmStoreRefCountLeak()
Review comment:
I think better catch and log it and also throw AssertionError with
explanation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
