[
https://issues.apache.org/jira/browse/PHOENIX-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271861#comment-17271861
]
ASF GitHub Bot commented on PHOENIX-5296:
-----------------------------------------
virajjasani commented on a change in pull request #1096:
URL: https://github.com/apache/phoenix/pull/1096#discussion_r563507218
##########
File path: phoenix-hbase-compat-2.3.0/pom.xml
##########
@@ -97,6 +97,18 @@
<version>${hbase23.compat.version}</version>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ <version>${slf4j.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
Review comment:
For 4.x `Uninterruptibles` is in beta version based on guava version
that we use so i used this:
https://github.com/apache/phoenix/pull/1097/files#diff-d12329d4796498b9880a54bb4b6d681f7ee42b924536bf5247791f372329cd9fR61
However, i feel using `Uninterruptibles.sleepUninterruptibly` more
comfortably as we don't have to catch `InterruptedException` and it is not
interruptible. But i agree with your point on not introducing more dependency
so let me replicate same logic as 4.x.
##########
File path: phoenix-hbase-compat-2.3.0/pom.xml
##########
@@ -97,6 +97,18 @@
<version>${hbase23.compat.version}</version>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ <version>${slf4j.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Ensure store file reader refcount is zero at end of relevant unit tests
> -----------------------------------------------------------------------
>
> Key: PHOENIX-5296
> URL: https://issues.apache.org/jira/browse/PHOENIX-5296
> Project: Phoenix
> Issue Type: Test
> Reporter: Andrew Kyle Purtell
> Assignee: Viraj Jasani
> Priority: Major
> Labels: phoenix-hardening
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5296.4.x.000.patch,
> PHOENIX-5296.master.000.patch, PHOENIX-5296.master.000.patch
>
>
> Unit and integration tests for functional areas where the implementation
> wraps scanners and uses a delegate pattern should check at the end of the
> test that no scanners were leaked (check that all scanners including the
> inner scanners were properly closed) by testing that the store reader
> reference count is zero on all stores.
> HBASE-22459 will offer a new metric and API which exposes this information.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
