[
https://issues.apache.org/jira/browse/PHOENIX-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272010#comment-17272010
]
ASF GitHub Bot commented on PHOENIX-5296:
-----------------------------------------
stoty commented on pull request #1096:
URL: https://github.com/apache/phoenix/pull/1096#issuecomment-767428915
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 14s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
1 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 4m 53s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 11m 17s | master passed |
| +0 | hbaserecompile | 22m 22s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 30s | master passed |
| +1 :green_heart: | checkstyle | 0m 41s | master passed |
| +1 :green_heart: | javadoc | 2m 7s | master passed |
| +0 :ok: | spotbugs | 0m 36s | phoenix-hbase-compat-2.4.0 in master
has 1 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 35s | phoenix-hbase-compat-2.3.0 in master
has 1 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 32s | phoenix-hbase-compat-2.2.5 in master
has 1 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 34s | phoenix-hbase-compat-2.1.6 in master
has 1 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 2m 53s | phoenix-core in master has 955 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 8m 9s | the patch passed |
| +0 | hbaserecompile | 14m 30s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 33s | the patch passed |
| +1 :green_heart: | javac | 1m 33s | the patch passed |
| -1 :x: | checkstyle | 0m 42s | root: The patch generated 23 new + 108
unchanged - 0 fixed = 131 total (was 108) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 2m 7s | the patch passed |
| -1 :x: | spotbugs | 0m 47s | phoenix-hbase-compat-2.4.0 generated 1
new + 1 unchanged - 0 fixed = 2 total (was 1) |
| -1 :x: | spotbugs | 0m 49s | phoenix-hbase-compat-2.3.0 generated 1
new + 1 unchanged - 0 fixed = 2 total (was 1) |
| +1 :green_heart: | spotbugs | 0m 47s | phoenix-hbase-compat-2.2.5 in
the patch passed. |
| +1 :green_heart: | spotbugs | 0m 46s | phoenix-hbase-compat-2.1.6 in
the patch passed. |
| +1 :green_heart: | spotbugs | 3m 13s | phoenix-core generated 0 new +
954 unchanged - 1 fixed = 954 total (was 955) |
||| _ Other Tests _ |
| -1 :x: | unit | 118m 3s | root in the patch failed. |
| +1 :green_heart: | asflicense | 1m 10s | The patch does not generate
ASF License warnings. |
| | | 180m 30s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-hbase-compat-2.4.0 |
| |
org.apache.phoenix.compat.hbase.CompatUtil.isAnyStoreRefCountLeaked(Admin)
calls Thread.sleep() with a lock held At CompatUtil.java:lock held At
CompatUtil.java:[line 109] |
| FindBugs | module:phoenix-hbase-compat-2.3.0 |
| |
org.apache.phoenix.compat.hbase.CompatUtil.isAnyStoreRefCountLeaked(Admin)
calls Thread.sleep() with a lock held At CompatUtil.java:lock held At
CompatUtil.java:[line 108] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1096/26/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1096 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs
hbaserebuild hbaseanti checkstyle compile xml |
| uname | Linux 089759f1ce69 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17
17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / ba47233 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1096/26/artifact/yetus-general-check/output/diff-checkstyle-root.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1096/26/artifact/yetus-general-check/output/new-spotbugs-phoenix-hbase-compat-2.4.0.html
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1096/26/artifact/yetus-general-check/output/new-spotbugs-phoenix-hbase-compat-2.3.0.html
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1096/26/artifact/yetus-general-check/output/patch-unit-root.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1096/26/testReport/
|
| Max. process+thread count | 10892 (vs. ulimit of 30000) |
| modules | C: phoenix-hbase-compat-2.4.0 phoenix-hbase-compat-2.3.0
phoenix-hbase-compat-2.2.5 phoenix-hbase-compat-2.1.6 phoenix-core U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1096/26/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Ensure store file reader refcount is zero at end of relevant unit tests
> -----------------------------------------------------------------------
>
> Key: PHOENIX-5296
> URL: https://issues.apache.org/jira/browse/PHOENIX-5296
> Project: Phoenix
> Issue Type: Test
> Reporter: Andrew Kyle Purtell
> Assignee: Viraj Jasani
> Priority: Major
> Labels: phoenix-hardening
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5296.4.x.000.patch,
> PHOENIX-5296.master.000.patch, PHOENIX-5296.master.000.patch
>
>
> Unit and integration tests for functional areas where the implementation
> wraps scanners and uses a delegate pattern should check at the end of the
> test that no scanners were leaked (check that all scanners including the
> inner scanners were properly closed) by testing that the store reader
> reference count is zero on all stores.
> HBASE-22459 will offer a new metric and API which exposes this information.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
