stoty commented on a change in pull request #1129:
URL: https://github.com/apache/phoenix/pull/1129#discussion_r569561789
##########
File path: phoenix-assembly/src/build/components/all-common-dependencies.xml
##########
@@ -28,6 +28,8 @@
<unpack>false</unpack>
<outputDirectory>/lib</outputDirectory>
<includes>
+
<include>org.apache.phoenix:phoenix-hbase-compat-${hbase.compat.version}</include>
Review comment:
Though IIRC pherf already uses phoenix-client, so it may not be.
But we are shipping so much junk in /lib, that one more jar doesn't make a
difference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
