[
https://issues.apache.org/jira/browse/PHOENIX-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278875#comment-17278875
]
ASF GitHub Bot commented on PHOENIX-6114:
-----------------------------------------
stoty commented on pull request #1132:
URL: https://github.com/apache/phoenix/pull/1132#issuecomment-773358753
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 17s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 5m 23s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 11m 47s | 4.x passed |
| +1 :green_heart: | compile | 2m 5s | 4.x passed |
| +1 :green_heart: | javadoc | 2m 8s | 4.x passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 7m 34s | root in the patch failed. |
| +1 :green_heart: | compile | 1m 56s | the patch passed |
| +1 :green_heart: | javac | 1m 56s | the patch passed |
| +1 :green_heart: | pylint | 0m 10s | The patch generated 0 new + 87
unchanged - 31 fixed = 87 total (was 118) |
| -1 :x: | whitespace | 0m 0s | The patch 1 line(s) with tabs. |
| +1 :green_heart: | xml | 0m 6s | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 2m 4s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 275m 13s | root in the patch failed. |
| -1 :x: | asflicense | 0m 33s | The patch generated 1 ASF License
warnings. |
| | | 311m 30s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.pherf.PherfMainIT |
| | phoenix.pherf.DataIngestIT |
| | phoenix.pherf.SchemaReaderIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1132/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1132 |
| Optional Tests | dupname asflicense pylint xml javac javadoc unit compile |
| uname | Linux 289ad647350d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 83f8f73 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| mvninstall |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1132/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
|
| whitespace |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1132/1/artifact/yetus-general-check/output/whitespace-tabs.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1132/1/artifact/yetus-general-check/output/patch-unit-root.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1132/1/testReport/
|
| asflicense |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1132/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
|
| Max. process+thread count | 4831 (vs. ulimit of 30000) |
| modules | C: phoenix-pherf phoenix-assembly . U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1132/1/console
|
| versions | git=2.7.4 maven=3.3.9 pylint=2.4.4 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Create shaded phoenix-pherf and remove lib dir from assembly
> ------------------------------------------------------------
>
> Key: PHOENIX-6114
> URL: https://issues.apache.org/jira/browse/PHOENIX-6114
> Project: Phoenix
> Issue Type: Improvement
> Components: core
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
>
> The Phoenix assembly has a poorly maintained lib directory, with dependencies
> that we are for submodules that have since been moved to phoenix-queryserver.
> The core phoenix jars are shaded, and do not or use the libraries here.
> phoenix-tracing-webapp is not included in the assembly, and thus does not
> need dependencies there.
> That leaves phoenix-pherf as a possible consumer of these dependencies.
> I propose building refactoring phoenix-pherf similarly to
> phoenix-queryserver, as a mostly self-contained shaded JAR, that only depends
> on phoenix-client, and has the rest of its dependencies shaded in.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
