[ 
https://issues.apache.org/jira/browse/PHOENIX-6409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301033#comment-17301033
 ] 

ASF GitHub Bot commented on PHOENIX-6409:
-----------------------------------------

stoty commented on pull request #1166:
URL: https://github.com/apache/phoenix/pull/1166#issuecomment-798821124


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 34s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  16m 58s |  master passed  |
   | +0 |  hbaserecompile  |  23m 52s |  HBase recompiled.  |
   | +1 :green_heart: |  compile  |   1m  3s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 41s |  master passed  |
   | +1 :green_heart: |  javadoc  |   1m  4s |  master passed  |
   | +0 :ok: |  spotbugs  |   3m 21s |  phoenix-core in master has 959 extant 
spotbugs warnings.  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   8m 48s |  the patch passed  |
   | +0 |  hbaserecompile  |  19m 17s |  HBase recompiled.  |
   | +1 :green_heart: |  compile  |   1m  6s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m  6s |  the patch passed  |
   | -1 :x: |  checkstyle  |   0m 41s |  phoenix-core: The patch generated 13 
new + 455 unchanged - 2 fixed = 468 total (was 457)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  javadoc  |   0m 54s |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   3m 23s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 110m 23s |  phoenix-core in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 44s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 166m 52s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | 
phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1166/3/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/phoenix/pull/1166 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs 
hbaserebuild hbaseanti checkstyle compile |
   | uname | Linux af87004b417a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-personality.sh |
   | git revision | master / 868c8ef |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1166/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
 |
   | unit | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1166/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1166/3/testReport/
 |
   | Max. process+thread count | 14792 (vs. ulimit of 30000) |
   | modules | C: phoenix-core U: phoenix-core |
   | Console output | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1166/3/console
 |
   | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Include local index uncovered columns merge in explain plan.
> ------------------------------------------------------------
>
>                 Key: PHOENIX-6409
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6409
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Minor
>             Fix For: 5.1.1, 4.16.1, 5.2.0
>
>
> This is a nice to have.
> It would be nice if EXPLAIN would show that uncovered columns have to be 
> merged during the index scan.
> (Not sure that is easily doable - filing it here for the record.)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to