[ 
https://issues.apache.org/jira/browse/PHOENIX-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344883#comment-17344883
 ] 

ASF GitHub Bot commented on PHOENIX-6471:
-----------------------------------------

stoty commented on pull request #1235:
URL: https://github.com/apache/phoenix/pull/1235#issuecomment-841502449


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m  2s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +0 |  hbaserecompile  |   6m 43s |  HBase recompiled.  |
   ||| _ Patch Compile Tests _ |
   | +0 |  hbaserecompile  |   6m 35s |  HBase recompiled.  |
   | +1 :green_heart: |  shellcheck  |   0m  0s |  There were no new shellcheck 
issues.  |
   | +1 :green_heart: |  shelldocs  |   0m  4s |  There were no new shelldocs 
issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   ||| _ Other Tests _ |
   | -1 :x: |  asflicense  |   0m 24s |  The patch generated 614 ASF License 
warnings.  |
   |  |   |  15m 33s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1235/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/phoenix/pull/1235 |
   | Optional Tests | dupname asflicense shellcheck shelldocs |
   | uname | Linux 5e5fc7432390 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-personality.sh |
   | git revision | master / eeebc8e |
   | asflicense | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1235/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
 |
   | Max. process+thread count | 96 (vs. ulimit of 30000) |
   | modules | C: . U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1235/1/console
 |
   | versions | git=2.7.4 maven=3.3.9 shellcheck=0.7.0 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Revert PHOENIX-5387 to remove unneeded CPL 1.0 license
> ------------------------------------------------------
>
>                 Key: PHOENIX-6471
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6471
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.16.1
>            Reporter: Ankit Singhal
>            Assignee: Ankit Singhal
>            Priority: Blocker
>
> As [~jmclean] pointed on release vote [1] and after checking the code , we 
> don't include any source or bundle the below dependency requiring CPL license 
> in any of the artifacts we distribute, so we shoud be avoiding it's 
> unnecessary mention in our LICENSE for both source and convenience binaries 
> as per the ASF policy [2][3]
> {code:java}
>                  <dependency>
>                         <groupId>com.github.stefanbirkner</groupId>
>                         <artifactId>system-rules</artifactId>
>                         <version>1.8.0</version>
>                 </dependency>
>  {code}
> [1] 
> [https://lists.apache.org/x/thread.html/r903c814a13acf996309b9996262b14d85d219aaace22a39ea7233ef1@%3Cdev.phoenix.apache.org%3E]
> [2][https://www.apache.org/legal/resolved.html#category-b]
> [3][https://infra.apache.org/licensing-howto.html#guiding]
> FYI [~yanxinyi], [~vjasani]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to