[
https://issues.apache.org/jira/browse/PHOENIX-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17381193#comment-17381193
]
ASF GitHub Bot commented on PHOENIX-6510:
-----------------------------------------
stoty commented on pull request #1264:
URL: https://github.com/apache/phoenix/pull/1264#issuecomment-880529472
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 3s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 28m 40s | master passed |
| +0 | hbaserecompile | 37m 37s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 19s | master passed |
| +1 :green_heart: | checkstyle | 0m 52s | master passed |
| +1 :green_heart: | javadoc | 1m 3s | master passed |
| +0 :ok: | spotbugs | 4m 10s | phoenix-core in master has 964 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 19m 18s | the patch passed |
| +0 | hbaserecompile | 32m 12s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 20s | the patch passed |
| +1 :green_heart: | javac | 1m 20s | the patch passed |
| -1 :x: | checkstyle | 0m 52s | phoenix-core: The patch generated 5
new + 507 unchanged - 8 fixed = 512 total (was 515) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 1m 2s | the patch passed |
| +1 :green_heart: | spotbugs | 4m 28s | phoenix-core generated 0 new +
960 unchanged - 4 fixed = 960 total (was 964) |
||| _ Other Tests _ |
| -1 :x: | unit | 117m 56s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 42s | The patch does not generate
ASF License warnings. |
| | | 203m 58s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.LogicalTableNameIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1264/6/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1264 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs
hbaserebuild hbaseanti checkstyle compile |
| uname | Linux ea075d658a16 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 9c9dd0b |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1264/6/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1264/6/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1264/6/testReport/
|
| Max. process+thread count | 14521 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1264/6/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Double-Checked Locking field must be volatile
> ---------------------------------------------
>
> Key: PHOENIX-6510
> URL: https://issues.apache.org/jira/browse/PHOENIX-6510
> Project: Phoenix
> Issue Type: Bug
> Reporter: Wei-Chiu Chuang
> Assignee: Wei-Chiu Chuang
> Priority: Major
>
> There are three places where the field used for double-checked locking isn't
> volatile. Change them to volatile to ensure thread-safety.
> More details on the double-checked locking paradigm:
> https://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
