stoty commented on pull request #1265: URL: https://github.com/apache/phoenix/pull/1265#issuecomment-880704184
:broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 5m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 23m 57s | master passed | | +0 | hbaserecompile | 30m 51s | HBase recompiled. | | +1 :green_heart: | compile | 1m 6s | master passed | | +1 :green_heart: | checkstyle | 0m 46s | master passed | | +1 :green_heart: | javadoc | 0m 53s | master passed | | +0 :ok: | spotbugs | 3m 18s | phoenix-core in master has 962 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 16m 53s | the patch passed | | +0 | hbaserecompile | 27m 18s | HBase recompiled. | | +1 :green_heart: | compile | 1m 6s | the patch passed | | +1 :green_heart: | javac | 1m 6s | the patch passed | | -1 :x: | checkstyle | 0m 45s | phoenix-core: The patch generated 28 new + 856 unchanged - 15 fixed = 884 total (was 871) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 51s | the patch passed | | -1 :x: | spotbugs | 3m 33s | phoenix-core generated 2 new + 962 unchanged - 0 fixed = 964 total (was 962) | ||| _ Other Tests _ | | -1 :x: | unit | 156m 53s | phoenix-core in the patch failed. | | +1 :green_heart: | asflicense | 0m 53s | The patch does not generate ASF License warnings. | | | | 233m 36s | | | Reason | Tests | |-------:|:------| | FindBugs | module:phoenix-core | | | org.apache.phoenix.mapreduce.AbstractBulkLoadTool.loadData(Configuration, CommandLine) may fail to clean up java.sql.Statement Obligation to clean up resource created at AbstractBulkLoadTool.java:clean up java.sql.Statement Obligation to clean up resource created at AbstractBulkLoadTool.java:[line 235] is not discharged | | | org.apache.phoenix.mapreduce.AbstractBulkLoadTool.loadData(Configuration, CommandLine) may fail to close Statement At AbstractBulkLoadTool.java:close Statement At AbstractBulkLoadTool.java:[line 235] | | Failed junit tests | phoenix.monitoring.PhoenixTableLevelMetricsIT | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1265/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1265 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile | | uname | Linux 6f1fc8332592 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / 00d9031 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1265/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1265/3/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1265/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1265/3/testReport/ | | Max. process+thread count | 6321 (vs. ulimit of 30000) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1265/3/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
