abhishek-chouhan commented on pull request #1250: URL: https://github.com/apache/phoenix/pull/1250#issuecomment-883531385
Have we looked at the scanId that we already have in BaseResultIterators? Seems to be scarcely used. However, we would want to have a single notion of a queryId, unless needed otherwise. It also looks like the clients need to set this explicitly? Ideally we would not want the clients going through the internal implementations of phoenix (PhoenixStatement and their derivates in this case). Having phoenix generate the queryId implicitly makes more sense IMO. The notion also seems useful not only for tracing but also for debugging. At the moment, logging in phoenix is scattered and hard to correlate with the actual query. @ArkenKiran -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
