stoty commented on pull request #1271:
URL: https://github.com/apache/phoenix/pull/1271#issuecomment-885003758


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 28s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 
1 new or modified test files.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   5m 21s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  17m 39s |  master passed  |
   | +0 |  hbaserecompile  |  29m 52s |  HBase recompiled.  |
   | +1 :green_heart: |  compile  |   1m 35s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   2m  3s |  master passed  |
   | +1 :green_heart: |  javadoc  |   1m  9s |  master passed  |
   | +0 :ok: |  spotbugs  |   3m  3s |  phoenix-core in master has 964 extant 
spotbugs warnings.  |
   | +0 :ok: |  spotbugs  |   0m 43s |  phoenix-tools in master has 5 extant 
spotbugs warnings.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  13m 38s |  the patch passed  |
   | +0 |  hbaserecompile  |  19m 59s |  HBase recompiled.  |
   | +1 :green_heart: |  compile  |   1m 34s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 34s |  the patch passed  |
   | -1 :x: |  checkstyle  |   1m 49s |  phoenix-core: The patch generated 428 
new + 2618 unchanged - 20 fixed = 3046 total (was 2638)  |
   | +1 :green_heart: |  checkstyle  |   0m 16s |  phoenix-tools: The patch 
generated 0 new + 60 unchanged - 361 fixed = 60 total (was 421)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  xml  |   0m  1s |  The patch has no ill-formed XML 
file.  |
   | +1 :green_heart: |  javadoc  |   1m  9s |  the patch passed  |
   | -1 :x: |  spotbugs  |   3m 19s |  phoenix-core generated 6 new + 964 
unchanged - 0 fixed = 970 total (was 964)  |
   | +1 :green_heart: |  spotbugs  |   0m 54s |  phoenix-tools generated 0 new 
+ 3 unchanged - 2 fixed = 3 total (was 5)  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 111m 54s |  phoenix-core in the patch failed.  |
   | -1 :x: |  unit  |   3m 41s |  phoenix-tools in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   1m 24s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 188m 43s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:phoenix-core |
   |  |  Found reliance on default encoding in 
org.apache.phoenix.schematool.SchemaSynthesisProcessor.getQueriesFromFile(String):in
 
org.apache.phoenix.schematool.SchemaSynthesisProcessor.getQueriesFromFile(String):
 new java.io.FileReader(File)  At SchemaSynthesisProcessor.java:[line 211] |
   |  |  Null passed for non-null parameter of new 
org.apache.phoenix.parse.SQLParser(String) in 
org.apache.phoenix.schematool.SchemaSynthesisProcessor.synthesize(String, 
String)  Method invoked at SchemaSynthesisProcessor.java:of new 
org.apache.phoenix.parse.SQLParser(String) in 
org.apache.phoenix.schematool.SchemaSynthesisProcessor.synthesize(String, 
String)  Method invoked at SchemaSynthesisProcessor.java:[line 80] |
   |  |  Null passed for non-null parameter of new 
org.apache.phoenix.parse.SQLParser(String) in 
org.apache.phoenix.schematool.SchemaSynthesisProcessor.synthesize(String, 
String)  Method invoked at SchemaSynthesisProcessor.java:of new 
org.apache.phoenix.parse.SQLParser(String) in 
org.apache.phoenix.schematool.SchemaSynthesisProcessor.synthesize(String, 
String)  Method invoked at SchemaSynthesisProcessor.java:[line 81] |
   |  |  
org.apache.phoenix.schematool.SchemaSynthesisProcessor.getQueriesFromFile(String)
 may fail to close stream  At SchemaSynthesisProcessor.java:stream  At 
SchemaSynthesisProcessor.java:[line 211] |
   |  |  Invocation of toString on Throwable.getStackTrace() in 
org.apache.phoenix.util.QueryUtil.getShowCreateStatementStmt(PhoenixConnection, 
String, TableName)  At QueryUtil.java:in 
org.apache.phoenix.util.QueryUtil.getShowCreateStatementStmt(PhoenixConnection, 
String, TableName)  At QueryUtil.java:[line 788] |
   |  |  
org.apache.phoenix.util.QueryUtil.getShowCreateStatementStmt(PhoenixConnection, 
String, TableName) may fail to clean up java.sql.Statement on checked exception 
 Obligation to clean up resource created at QueryUtil.java:to clean up 
java.sql.Statement on checked exception  Obligation to clean up resource 
created at QueryUtil.java:[line 804] is not discharged |
   | Failed junit tests | phoenix.end2end.BackwardCompatibilityIT |
   |   | phoenix.schema.SchemaToolExtractionIT |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1271/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/phoenix/pull/1271 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs 
hbaserebuild hbaseanti checkstyle compile xml |
   | uname | Linux 36dc51b6ef0f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-personality.sh |
   | git revision | master / 6842c1d |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1271/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
 |
   | spotbugs | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1271/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
 |
   | unit | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1271/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
 |
   | unit | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1271/1/artifact/yetus-general-check/output/patch-unit-phoenix-tools.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1271/1/testReport/
 |
   | Max. process+thread count | 14695 (vs. ulimit of 30000) |
   | modules | C: phoenix-core phoenix-tools U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1271/1/console
 |
   | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to