stoty commented on a change in pull request #1276:
URL: https://github.com/apache/phoenix/pull/1276#discussion_r678944457
##########
File path: pom.xml
##########
@@ -99,7 +99,7 @@
<antlr-input.dir>src/main/antlr3</antlr-input.dir>
<antlr-output.dir>target/generated-sources/antlr3</antlr-output.dir>
<test.output.tofile>true</test.output.tofile>
- <top.dir>${project.basedir}</top.dir>
+ <top.dir>${project.basedir}/..</top.dir>
Review comment:
top.dir in the submodules doesn't seem to do anything.
I suggest that you delete it from those to simplify the maven setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
