[
https://issues.apache.org/jira/browse/PHOENIX-5543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390728#comment-17390728
]
ASF GitHub Bot commented on PHOENIX-5543:
-----------------------------------------
stoty commented on pull request #1278:
URL: https://github.com/apache/phoenix/pull/1278#issuecomment-890068290
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 35s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
1 new or modified test files. |
||| _ 4.16 Compile Tests _ |
| +0 :ok: | mvndep | 5m 17s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 13m 40s | 4.16 passed |
| +1 :green_heart: | compile | 1m 39s | 4.16 passed |
| +1 :green_heart: | checkstyle | 1m 27s | 4.16 passed |
| +1 :green_heart: | javadoc | 1m 3s | 4.16 passed |
| +0 :ok: | spotbugs | 3m 9s | phoenix-core in 4.16 has 948 extant
spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 55s | phoenix-pherf in 4.16 has 42 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 12m 45s | the patch passed |
| +1 :green_heart: | compile | 2m 19s | the patch passed |
| +1 :green_heart: | javac | 2m 19s | the patch passed |
| -1 :x: | checkstyle | 1m 38s | phoenix-core: The patch generated 142
new + 1080 unchanged - 103 fixed = 1222 total (was 1183) |
| -1 :x: | checkstyle | 0m 17s | phoenix-pherf: The patch generated 1
new + 68 unchanged - 6 fixed = 69 total (was 74) |
| -1 :x: | whitespace | 0m 0s | The patch 1 line(s) with tabs. |
| +1 :green_heart: | javadoc | 1m 25s | the patch passed |
| -1 :x: | spotbugs | 4m 50s | phoenix-core generated 5 new + 943
unchanged - 5 fixed = 948 total (was 948) |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 143m 17s | phoenix-core in the patch passed.
|
| -1 :x: | unit | 7m 36s | phoenix-pherf in the patch failed. |
| +1 :green_heart: | asflicense | 0m 19s | The patch does not generate
ASF License warnings. |
| | | 205m 20s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | org.apache.phoenix.util.QueryUtil.getCatalogsStmt(PhoenixConnection)
may fail to clean up java.sql.Statement on checked exception Obligation to
clean up resource created at QueryUtil.java:up java.sql.Statement on checked
exception Obligation to clean up resource created at QueryUtil.java:[line 528]
is not discharged |
| | org.apache.phoenix.util.QueryUtil.getIndexInfoStmt(PhoenixConnection,
String, String, String, boolean, boolean) may fail to clean up
java.sql.Statement on checked exception Obligation to clean up resource
created at QueryUtil.java:boolean) may fail to clean up java.sql.Statement on
checked exception Obligation to clean up resource created at
QueryUtil.java:[line 635] is not discharged |
| | org.apache.phoenix.util.QueryUtil.getSchemasStmt(PhoenixConnection,
String, String) may fail to clean up java.sql.Statement on checked exception
Obligation to clean up resource created at QueryUtil.java:to clean up
java.sql.Statement on checked exception Obligation to clean up resource
created at QueryUtil.java:[line 560] is not discharged |
| |
org.apache.phoenix.util.QueryUtil.getSuperTablesStmt(PhoenixConnection, String,
String, String) may fail to clean up java.sql.Statement on checked exception
Obligation to clean up resource created at QueryUtil.java:fail to clean up
java.sql.Statement on checked exception Obligation to clean up resource
created at QueryUtil.java:[line 590] is not discharged |
| | org.apache.phoenix.util.QueryUtil.getTablesStmt(PhoenixConnection,
String, String, String, String[]) may fail to clean up java.sql.Statement on
checked exception Obligation to clean up resource created at
QueryUtil.java:may fail to clean up java.sql.Statement on checked exception
Obligation to clean up resource created at QueryUtil.java:[line 765] is not
discharged |
| Failed junit tests | phoenix.pherf.PherfMainIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1278 |
| JIRA Issue | PHOENIX-5543 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux e37a2dc1b998 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.16 / 3a4339e |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-pherf.txt
|
| whitespace |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-general-check/output/whitespace-tabs.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-general-check/output/patch-unit-phoenix-pherf.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1278/2/testReport/
|
| Max. process+thread count | 5703 (vs. ulimit of 30000) |
| modules | C: phoenix-core phoenix-pherf U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1278/2/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Implement show schemas / show tables SQL commands
> -------------------------------------------------
>
> Key: PHOENIX-5543
> URL: https://issues.apache.org/jira/browse/PHOENIX-5543
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.15.0, 5.1.0
> Reporter: Bharath Vissapragada
> Assignee: Bharath Vissapragada
> Priority: Minor
> Fix For: 5.1.0, 4.16.1, 4.17.0
>
> Attachments: PHOENIX-5543-4.x.v1.patch, PHOENIX-5543.master.v1.patch,
> PHOENIX-5543.master.v2.patch, PHOENIX-5543.master.v3.patch
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Currently users rely on {{!tables}} and {{!schemas}} commands provided by
> sqlline which pulls the information using the standard JDBC metadata calls
> like {{getTables()}} and {{getSchemas()}}.
> Most other databases (like mysql[1,2]) implement these as first class SQL
> commands that gives the user more flexibility in querying by adding necessary
> filters and looking up for table information in specific schemas. The ask
> here is to implement the following SQL commands.
> {noformat}
> SHOW SCHEMAS [LIKE '<pattern>']
> SHOW TABLES [IN <schema>] [LIKE '<pattern>']
> {noformat}
> [1] https://dev.mysql.com/doc/refman/8.0/en/show-tables.html
> [2] https://dev.mysql.com/doc/refman/8.0/en/show-databases.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
