alejandro-anadon commented on pull request #1342:
URL: https://github.com/apache/phoenix/pull/1342#issuecomment-964417332
You are right. With 'ptr.getLength() > 0' is enough.
At the begining I thought that only 'o' should be checked.
Later I added ptr.lenght (it was necesary for default values) without
cheking if 'o != null' could be removed.
Finally, as you sugest, I tested with only 'ptr.getLength() > 0'.
And, of course, if there is not something that I do not see, It can be
removed.
About the test, in my enviroment, I tested the changes sereval times. the
results are:
default-test -> never fails
ParallelStatsEnabledTest -> never fails
ParallelStatsDisabledTest -> never fails
NeedTheirOwnClusterTests -> randon failures
Those random test are not allways the same failures.
for example, in my last test, the failure is in:
'PermissionNSEnabledWithCustomAccessControllerIT>BasePermissionsIT.testSystemTablePermissions:1027->BasePermissionsIT.verifyAllowed:894->BasePermissionsIT.verifyAllowed:901
» UndeclaredThrowable'.
But other time, I have
'PhoenixMetricsIT.testGlobalPhoenixMetricsForQueries:199' (now I don't know if
that error was with jdk8 or jdk11)
Another time I had:
'MaxConcurrentConnectionsIT.testDeleteRuntimeFailureClosesConnections:124
Found 1 connections still open. expected:<0> but was:<1>'
and
'LogicalTableNameIT.testUpdatePhysicalIndexTableName_runScrutiny:215->LogicalTableNameBaseIT.test_IndexTableChange:187
» SnapshotCreation'.
Summing up, in 'NeedTheirOwnClusterTests', I can't give a fault pattern, but
I think the faults I have have nothing to do with the change I am proposing.
Finally, when maven is going to build the report with jacoco, it allways
fails (in my enviroment).
[ERROR] Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.7:report
(report) on project phoenix-core: Execution report of goal
org.jacoco:jacoco-maven-plugin:0.8.7:report failed: Incompatible execution data
for class org/apache/hadoop/hbase/regionserver/MetricsRegionAggregateSourceImpl
with id 2687434e0753a2bc. -> [Help 1]
(I drop the screen log of my last execution).
[PHOENIX-6583-SCREEN-LOG-IN-BUILDING.txt](https://github.com/apache/phoenix/files/7507090/PHOENIX-6583-SCREEN-LOG-IN-BUILDING.txt)
I wanted to point out that, regarding test, I had lots of problems and fails
when using 'openjdk version "11.0.12" 2021-07-20' with semi-random test
failures. So I decided to change all to 'java version "1.8.0_202"'.
Since them, I only have random failures in NeedTheirOwnClusterTests . I
followed the instruction in
https://github.com/apache/phoenix/blob/master/BUILDING.md . so I sugest, if it
is necesary a specific jvm to compile and test, it is advisable to indicate it
that file.
Besides, when you ask to 'Please also fix the remaining spaces at the end of
lines.', I thing that there is some king of cache with file
'phoenix-core/src/it/java/org/apache/phoenix/end2end/BinaryTypeIT.java' beacuse
it was removed from the branch in the commit eae4b11. I saw several times to
"remove spaces' in that file. But the file is removed. You can check it int the
PHOENIX-6583 branch on alejandro-anadon/phoenix.
(https://github.com/alejandro-anadon/phoenix).
In the checkstile chekers I see follow (but not allways apears... sometimes
appers, another not):
phoenix-core/src/it/java/org/apache/phoenix/end2end/BinaryTypeIT.java:40:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BinaryTypeIT.java:42:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BinaryTypeIT.java:44:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BinaryTypeIT.java:46:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BinaryTypeIT.java:49:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BinaryTypeIT.java:51:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BinaryTypeIT.java:52:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BinaryTypeIT.java:59:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BinaryTypeIT.java:66:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BinaryTypeIT.java:73:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BinaryTypeIT.java:80:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BinaryTypeIT.java:81:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BinaryTypeIT.java:84:
But that file does not exist anymore. The test that I propose was moved to
phoenix-core/src/it/java/org/apache/phoenix/end2end/NullIT.java as you sugested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
