gokceni commented on a change in pull request #1366:
URL: https://github.com/apache/phoenix/pull/1366#discussion_r773370346
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/schema/transform/Transform.java
##########
@@ -157,64 +307,70 @@ public static void addTransform(
}
- public static SystemTransformRecord getTransformRecord(
- String schema, String logicalTableName, String logicalParentName,
String tenantId, PhoenixConnection connection) throws SQLException {
- try (ResultSet resultSet = connection.prepareStatement("SELECT " +
- PhoenixDatabaseMetaData.TENANT_ID + ", " +
- PhoenixDatabaseMetaData.TABLE_SCHEM + ", " +
- PhoenixDatabaseMetaData.LOGICAL_TABLE_NAME + ", " +
- PhoenixDatabaseMetaData.NEW_PHYS_TABLE_NAME + ", " +
- PhoenixDatabaseMetaData.TRANSFORM_TYPE + ", " +
- PhoenixDatabaseMetaData.LOGICAL_PARENT_NAME + ", " +
- PhoenixDatabaseMetaData.TRANSFORM_STATUS + ", " +
- PhoenixDatabaseMetaData.TRANSFORM_JOB_ID + ", " +
- PhoenixDatabaseMetaData.TRANSFORM_RETRY_COUNT + ", " +
- PhoenixDatabaseMetaData.TRANSFORM_START_TS + ", " +
- PhoenixDatabaseMetaData.TRANSFORM_END_TS + ", " +
- PhoenixDatabaseMetaData.OLD_METADATA + " , " +
- PhoenixDatabaseMetaData.NEW_METADATA + " , " +
- PhoenixDatabaseMetaData.TRANSFORM_FUNCTION +
- " FROM " + PhoenixDatabaseMetaData.SYSTEM_TRANSFORM_NAME + "
WHERE " +
- (Strings.isNullOrEmpty(tenantId) ? "" :
(PhoenixDatabaseMetaData.TENANT_ID + " ='" + tenantId + "' AND ")) +
- (Strings.isNullOrEmpty(schema) ? "" :
(PhoenixDatabaseMetaData.TABLE_SCHEM + " ='" + schema + "' AND ")) +
- PhoenixDatabaseMetaData.LOGICAL_TABLE_NAME + " ='" +
logicalTableName + "'" +
- (Strings.isNullOrEmpty(logicalParentName) ? "": (" AND " +
PhoenixDatabaseMetaData.LOGICAL_PARENT_NAME + "='" + logicalParentName + "'" ))
- ).executeQuery()) {
- if (resultSet.next()) {
- return
SystemTransformRecord.SystemTransformBuilder.build(resultSet);
+ public static void completeTransform(Connection connection, Configuration
configuration) throws Exception{
+ // Will be called from Reducer
+ long timestmp= EnvironmentEdgeManager.currentTimeMillis();
+ String tenantId = configuration.get(MAPREDUCE_TENANT_ID, null);
+ String fullOldTableName =
PhoenixConfigurationUtil.getInputTableName(configuration);
+ String schemaName =
SchemaUtil.getSchemaNameFromFullName(fullOldTableName);
+ String oldTableLogicalName =
SchemaUtil.getTableNameFromFullName(fullOldTableName);
+ String indexTableName =
SchemaUtil.getTableNameFromFullName(PhoenixConfigurationUtil.getIndexToolIndexTableName(configuration));
+ String logicaTableName = oldTableLogicalName;
+ String logicalParentName = null;
+ if (PhoenixConfigurationUtil.getTransformingTableType(configuration)
== IndexScrutinyTool.SourceTable.INDEX_TABLE_SOURCE)
+ if (!Strings.isNullOrEmpty(indexTableName)) {
+ logicaTableName = indexTableName;
+ logicalParentName = SchemaUtil.getTableName(schemaName,
oldTableLogicalName);
}
- return null;
- }
- }
-
- public static boolean checkIsTransformNeeded(MetaDataClient.MetaProperties
metaProperties, String schemaName,
- PTable table, String
logicalTableName, String parentTableName,
- String tenantId,
PhoenixConnection connection) throws SQLException {
- boolean isTransformNeeded = isTransformNeeded(metaProperties, table);
- if (isTransformNeeded) {
- SystemTransformRecord existingTransform =
Transform.getTransformRecord(schemaName, logicalTableName, parentTableName,
tenantId,connection);
- if (existingTransform != null && existingTransform.isActive()) {
- throw new SQLExceptionInfo.Builder(
-
SQLExceptionCode.CANNOT_TRANSFORM_ALREADY_TRANSFORMING_TABLE)
- .setMessage(" Only one transform at a time is allowed
")
-
.setSchemaName(schemaName).setTableName(logicalTableName).build().buildException();
+ boolean isPartial =
PhoenixConfigurationUtil.getIsPartialTransform(configuration);
+ SystemTransformRecord transformRecord = getTransformRecord(schemaName,
logicaTableName, logicalParentName,
+ tenantId, connection.unwrap(PhoenixConnection.class));
+ if (!isPartial) {
+ String newTableName =
SchemaUtil.getTableNameFromFullName(transformRecord.getNewPhysicalTableName());
+ PTable pNewTable = PhoenixRuntime.getTable(connection,
transformRecord.getNewPhysicalTableName());
+ PTable pOldTable = PhoenixRuntime.getTable(connection,
SchemaUtil.getTableName(schemaName,logicaTableName));
+ if (pOldTable.getImmutableStorageScheme() !=
pNewTable.getImmutableStorageScheme() ||
+ pOldTable.getEncodingScheme() !=
pNewTable.getEncodingScheme()) {
+ MetaDataClient.mutateTransformProperties(connection, tenantId,
schemaName, logicaTableName, newTableName,
+ pNewTable.getImmutableStorageScheme(),
pNewTable.getEncodingScheme());
+ // We need to update the columns's qualifiers as well
+ if (pOldTable.getEncodingScheme() !=
pNewTable.getEncodingScheme()) {
+ Short nextKeySeq = 0;
Review comment:
addColumnMutation checks for null value for keySeq.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
