[ 
https://issues.apache.org/jira/browse/PHOENIX-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531267#comment-17531267
 ] 

Geoffrey Jacoby commented on PHOENIX-6703:
------------------------------------------

+1 to excluding jetty and servlet dependencies from phoenix-core if they're not 
necessary. A quick look of the codebase shows that jetty's being used in 
phoenix-server (just as an exclusion) and phoenix-tracing-webapp, which make 
sense, but I don't see any use of it in phoenix-core.

> Exclude Jetty and servlet-api from phoenix-client
> -------------------------------------------------
>
>                 Key: PHOENIX-6703
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6703
>             Project: Phoenix
>          Issue Type: Improvement
>          Components: core
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>
> phoenix-client-embedded includes a Jetty server, and the Jetty API.
> I don't think that there is a legitimate reason to have a web server in a 
> JDBC driver.It adds bloat, and tries to do some stuff at startup which takes 
> time.
> More pressingly, the shaded javax.servlet classes conflict with minicluster, 
> which breaks the tests in phoenix-queryserver.
> Remove Jetty and the Servlet API from the shaded phoenix-client JAR.
> We could also consider excluding these dependencies in phoenix-core.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to