[
https://issues.apache.org/jira/browse/PHOENIX-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17537605#comment-17537605
]
ASF GitHub Bot commented on PHOENIX-6707:
-----------------------------------------
anmolnar commented on PR #1442:
URL: https://github.com/apache/phoenix/pull/1442#issuecomment-1127819791
@stoty I'm not sure what do you mean by "in QueryServices". That's an
interface which doesn't have logic.
In most places I see something like the following:
```
connection
.getQueryServices()
.getProps()
.getLong(QueryServices.SEQUENCE_CACHE_SIZE_ATTRIB,
QueryServicesOptions.DEFAULT_SEQUENCE_CACHE_SIZE);
```
getProps() gives you `ReadOnlyProps` which doesn't have getLongBytes
alternative.
> Use Configuration.getLongBytes where applicable
> -----------------------------------------------
>
> Key: PHOENIX-6707
> URL: https://issues.apache.org/jira/browse/PHOENIX-6707
> Project: Phoenix
> Issue Type: Improvement
> Components: core
> Reporter: Istvan Toth
> Assignee: Andor Molnar
> Priority: Minor
>
> Right now, we're using Configuration#getLong to read all byte values from
> properties.
> the Configuration object provides the #getLongBytes function, that lets the
> user specify the values with prefixes, i.e. 20m, 5k.
> Use getLongBytes where applicable.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
