[
https://issues.apache.org/jira/browse/PHOENIX-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569785#comment-17569785
]
ASF GitHub Bot commented on PHOENIX-6707:
-----------------------------------------
stoty commented on PR #1442:
URL: https://github.com/apache/phoenix/pull/1442#issuecomment-1192171232
Mostly looks good.
Can you add a small UT for getLongBytes() in ReadOnlyProps to improve test
coverage ?
> Use Configuration.getLongBytes where applicable
> -----------------------------------------------
>
> Key: PHOENIX-6707
> URL: https://issues.apache.org/jira/browse/PHOENIX-6707
> Project: Phoenix
> Issue Type: Improvement
> Components: core
> Reporter: Istvan Toth
> Assignee: Andor Molnar
> Priority: Minor
>
> Right now, we're using Configuration#getLong to read all byte values from
> properties.
> the Configuration object provides the #getLongBytes function, that lets the
> user specify the values with prefixes, i.e. 20m, 5k.
> Use getLongBytes where applicable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
