[GitHub] [phoenix] gjacoby126 commented on a diff in pull request #1453: changed the tenant id generation for unifrom distribution load generator

[GitBox]

gjacoby126 commented on code in PR #1453:
URL: https://github.com/apache/phoenix/pull/1453#discussion_r899231495


##########
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/mt/generators/UniformDistributionLoadEventGenerator.java:
##########
@@ -72,12 +76,22 @@ public UniformDistributionSampler(List<Operation> 
operationList, DataModel model
         public TenantOperationInfo nextSample() {
             int sampleIndex = this.distribution.nextInt(operationList.size());
             Operation op = operationList.get(sampleIndex);
+            int numTenants = 1;
+
+            if(tenantGroup.getNumTenants() != 0)
+            {

Review Comment:
   tiny nit: angle bracket on the previous line



##########
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/mt/generators/UniformDistributionLoadEventGenerator.java:
##########
@@ -72,12 +76,22 @@ public UniformDistributionSampler(List<Operation> 
operationList, DataModel model
         public TenantOperationInfo nextSample() {
             int sampleIndex = this.distribution.nextInt(operationList.size());
             Operation op = operationList.get(sampleIndex);
+            int numTenants = 1;
+
+            if(tenantGroup.getNumTenants() != 0)
+            {
+                numTenants = tenantGroup.getNumTenants();
+            }
 
             String tenantGroupId = tenantGroup.getId();
             String tenantIdPrefix = Strings
                     .padStart(tenantGroupId, loadProfile.getGroupIdLength(), 
'x');
+            // String formattedTenantId = 
String.format(loadProfile.getTenantIdFormat(),

Review Comment:
   nit: no need to add commented out code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org