stoty commented on code in PR #109:
URL: https://github.com/apache/phoenix-omid/pull/109#discussion_r946664347
##########
hbase-coprocessor/src/main/java/org/apache/omid/transaction/CellSkipFilterBase.java:
##########
@@ -53,21 +53,21 @@ public CellSkipFilterBase(Filter filter) {
*/
private boolean skipCellVersion(Cell cell) {
return skipColumn != null
- && CellUtil.matchingRow(cell, skipColumn.getRowArray(),
skipColumn.getRowOffset(),
+ && PrivateCellUtil.matchingRows(cell, skipColumn.getRowArray(),
skipColumn.getRowOffset(),
Review Comment:
Most of the server-side HBase Cell API is Private, which I think is a
mistake.
It should be Limited for coprocessor usage.
There is no way Phoenix can operate without those classes.
I think that in this case, making an exception for PrivateCellUtil is fine.
WDYT @gjacoby126 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
