[
https://issues.apache.org/jira/browse/PHOENIX-6052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644557#comment-17644557
]
Viraj Jasani commented on PHOENIX-6052:
---------------------------------------
[~mnpoonia] I am wondering that in your above example, if we were to introduce
a new metric for SYSTEM.CATALOG lookup as part of overall mutation (something
like GLOBAL_METADATA_LOOKUP_WITH_MUTATION_COMMIT_TIME), then we can calculate
that lookup time separately. Otherwise, I think we don't need _syscattime_ and
"{_}endTime + syscattime{_}". Rather, we can keep _startTime_ at the beginning
of sendBatch(), and after all three sendMutations() calls are done, we can
calculate GLOBAL_MUTATION_COMMIT_TIME as "{_}endTime - startTime{_}". WDYT?
cc [~shahrs87]
> GLOBAL_MUTATION_COMMIT_TIME metric doesn't include the time spent in syscat
> rpc's
> ---------------------------------------------------------------------------------
>
> Key: PHOENIX-6052
> URL: https://issues.apache.org/jira/browse/PHOENIX-6052
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Affects Versions: 4.14.3
> Reporter: Rushabh Shah
> Assignee: Aman Poonia
> Priority: Major
>
> Currently we measure the metric GLOBAL_MUTATION_COMMIT_TIME as the time spent
> just in htable.batch rpc for base and index tables.
> https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java#L1029-L1136
> We don't measure the time spent in
> MutationState#validateAndGetServerTimestamp which makes rpc to SYSTEM.CATALOG
> table and which is a part of commit phase.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
