jpisaac commented on code in PR #1543:
URL: https://github.com/apache/phoenix/pull/1543#discussion_r1047889490
##########
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataProtocol.java:
##########
@@ -118,8 +118,9 @@ public abstract class MetaDataProtocol extends
MetaDataService {
/** Version below which we fall back on the generic KeyValueBuilder */
public static final int CLIENT_KEY_VALUE_BUILDER_THRESHOLD =
VersionUtil.encodeVersion("0", "94", "14");
// Version at which we allow SYSTEM.CATALOG to split
- public static final int MIN_SPLITTABLE_SYSTEM_CATALOG =
VersionUtil.encodeVersion("5", "1", "0");
- public static final String MIN_SPLITTABLE_SYSTEM_CATALOG_VERSION = "5.1.0";
+ public static final int MIN_SPLITTABLE_SYSTEM_CATALOG =
Review Comment:
This complicates the checks for MIN_SPLITTABLE_SYSTEM_CATALOG (e.g =>
clientVersion < MIN_SPLITTABLE_SYSTEM_CATALOG)
Since MIN_SPLITTABLE_SYSTEM_CATALOG is not fixed it will need to be client
major version dependent.
@gjacoby126 @shahrs87 @virajjasani
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
