stoty commented on code in PR #1534:
URL: https://github.com/apache/phoenix/pull/1534#discussion_r1048149316
##########
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java:
##########
@@ -3540,11 +3540,18 @@ Collections.<Class<? extends Exception>> singletonList(
if
(!ConnectionQueryServicesImpl.this.upgradeRequired.get()) {
if (!isDoNotUpgradePropSet) {
createOtherSystemTables(metaConnection);
+
+ // When creating the tables above, DDL
statements are
+ // used. However, the CFD level
properties are not set
+ // via DDL commands, hence we are
explicitly setting
+ // few properties using the Admin API
below.
+
updateSystemSequenceWithCacheOnWriteProps(metaConnection);
Review Comment:
This call should be pushed into createOtherSystemTables, to improve
readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
