[
https://issues.apache.org/jira/browse/PHOENIX-6849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650397#comment-17650397
]
ASF GitHub Bot commented on PHOENIX-6849:
-----------------------------------------
gourabtaparia commented on code in PR #1547:
URL: https://github.com/apache/phoenix/pull/1547#discussion_r1054119904
##########
dev/misc_utils/git_jira_fix_version_check.py:
##########
@@ -91,11 +91,15 @@
print('\nAny resolved Jira with fixVersion ' + fix_version
+ ' but corresponding commit not present')
-print('Starting diff: ##############################################')
+
+# maxResults=None results in internal batching within the API
+# and it returns all the results back
all_issues_with_fix_version = jira.search_issues(
'project=' + jira_project_name + ' and status in (Resolved,Closed) and
fixVersion='
- + fix_version)
+ + fix_version, maxResults=None)
+print(f'Found {all_issues_with_fix_version.total} issues fixed in
{fix_version}')
Review Comment:
minor comment : Looks like the formatted string literal is supported from
python3.6 onwards -
https://docs.python.org/3/whatsnew/3.6.html#whatsnew36-pep498.
Is there any minimum python version support wrt the phoenix repo where the
current script should run ? As this might not be backward compatible with lower
versions.
> git_jira_fix_version_check.py does not retrieve all JIRAs for a fixed version
> -----------------------------------------------------------------------------
>
> Key: PHOENIX-6849
> URL: https://issues.apache.org/jira/browse/PHOENIX-6849
> Project: Phoenix
> Issue Type: Bug
> Reporter: Tanuj Khurana
> Assignee: Tanuj Khurana
> Priority: Major
>
> The below API only returns 50 results by default as per the documentation
> [jira.search_issues|https://jira.readthedocs.io/examples.html#searching]
> {code:java}
> all_issues_with_fix_version = jira.search_issues( 'project=' +
> jira_project_name + ' and status in (Resolved,Closed) and fixVersion=' +
> fix_version) {code}
> We need to fetch all the matching issues.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
