[
https://issues.apache.org/jira/browse/PHOENIX-6052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656175#comment-17656175
]
ASF GitHub Bot commented on PHOENIX-6052:
-----------------------------------------
gourabtaparia commented on code in PR #1546:
URL: https://github.com/apache/phoenix/pull/1546#discussion_r1064807671
##########
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java:
##########
@@ -1198,6 +1199,7 @@ private void sendBatch(Map<TableRef,
MultiRowMutationState> commitBatch, long[]
Map<TableInfo, List<Mutation>> physicalTableMutationMap =
Maps.newLinkedHashMap();
// add tracing for this operation
+ long startTime = EnvironmentEdgeManager.currentTimeMillis();
Review Comment:
nitpick : the above L 1201 "add tracing" comment was for line L 1203 - maybe
we can add your change just above that comment - to make the comment and code
nearby as last time.
##########
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java:
##########
@@ -1411,8 +1415,8 @@ public List<Mutation> getMutationList() {
child.stop();
child.stop();
shouldRetry = false;
- mutationCommitTime =
EnvironmentEdgeManager.currentTimeMillis() - startTime;
- GLOBAL_MUTATION_COMMIT_TIME.update(mutationCommitTime);
+// mutationCommitTime =
EnvironmentEdgeManager.currentTimeMillis() - startTime;
Review Comment:
Why this code commented ? Please fix this
##########
phoenix-core/src/main/java/org/apache/phoenix/monitoring/MetricType.java:
##########
@@ -208,23 +209,23 @@ private MetricType(String shortName, String description,
LogLevel logLevel, PDat
public String description() {
return description;
}
-
Review Comment:
nitpick : there are various changes fixing the extra spaces not part of the
change - should we skip this as part of this change ?
> GLOBAL_MUTATION_COMMIT_TIME metric doesn't include the time spent in syscat
> rpc's
> ---------------------------------------------------------------------------------
>
> Key: PHOENIX-6052
> URL: https://issues.apache.org/jira/browse/PHOENIX-6052
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Affects Versions: 4.14.3
> Reporter: Rushabh Shah
> Assignee: Aman Poonia
> Priority: Major
>
> Currently we measure the metric GLOBAL_MUTATION_COMMIT_TIME as the time spent
> just in htable.batch rpc for base and index tables.
> https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java#L1029-L1136
> We don't measure the time spent in
> MutationState#validateAndGetServerTimestamp which makes rpc to SYSTEM.CATALOG
> table and which is a part of commit phase.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
