[
https://issues.apache.org/jira/browse/PHOENIX-6052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656349#comment-17656349
]
ASF GitHub Bot commented on PHOENIX-6052:
-----------------------------------------
tkhurana commented on code in PR #1546:
URL: https://github.com/apache/phoenix/pull/1546#discussion_r1065226588
##########
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java:
##########
@@ -1214,6 +1216,8 @@ private void sendBatch(Map<TableRef,
MultiRowMutationState> commitBatch, long[]
serverTimeStamps == null ?
validateAndGetServerTimestamp(tableRef,
multiRowMutationState) :
serverTimeStamps[i++];
+ long syscatTime = EnvironmentEdgeManager.currentTimeMillis() -
startTime;
Review Comment:
Also, this is being called in a loop so you need to reset the value of
startTime for every iteration.
##########
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java:
##########
@@ -1214,6 +1216,8 @@ private void sendBatch(Map<TableRef,
MultiRowMutationState> commitBatch, long[]
serverTimeStamps == null ?
validateAndGetServerTimestamp(tableRef,
multiRowMutationState) :
serverTimeStamps[i++];
+ long syscatTime = EnvironmentEdgeManager.currentTimeMillis() -
startTime;
Review Comment:
@mnpoonia This is not the only place where we call
validateAndGetServerTimestamp. It is also called from here
https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java#L895
> GLOBAL_MUTATION_COMMIT_TIME metric doesn't include the time spent in syscat
> rpc's
> ---------------------------------------------------------------------------------
>
> Key: PHOENIX-6052
> URL: https://issues.apache.org/jira/browse/PHOENIX-6052
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Affects Versions: 4.14.3
> Reporter: Rushabh Shah
> Assignee: Aman Poonia
> Priority: Major
>
> Currently we measure the metric GLOBAL_MUTATION_COMMIT_TIME as the time spent
> just in htable.batch rpc for base and index tables.
> https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java#L1029-L1136
> We don't measure the time spent in
> MutationState#validateAndGetServerTimestamp which makes rpc to SYSTEM.CATALOG
> table and which is a part of commit phase.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
