[
https://issues.apache.org/jira/browse/PHOENIX-6851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677437#comment-17677437
]
ASF GitHub Bot commented on PHOENIX-6851:
-----------------------------------------
stoty commented on PR #1548:
URL: https://github.com/apache/phoenix/pull/1548#issuecomment-1384216159
If we do this, then IMO the code cleanup and the check should be committed
together.
One hand this would be a major PITA, for backports, etc.
On the other hand the current code looks horrible.
I don't have a strong opinion either way.
I think that this should be discussed on the dev@ list, as this is a very
intrusive change.
> Use spotless to format code in phoenix
> --------------------------------------
>
> Key: PHOENIX-6851
> URL: https://issues.apache.org/jira/browse/PHOENIX-6851
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Aman Poonia
> Assignee: Aman Poonia
> Priority: Major
>
> Similar to what hbase does we can use spotless plugin to format code.
> Idea is to include spotless check as part of mvn install so if format is
> wrong mvn install will fail similar to what hbase has.
>
> More info in
> https://issues.apache.org/jira/browse/HBASE-26617
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
