[ 
https://issues.apache.org/jira/browse/PHOENIX-6937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722101#comment-17722101
 ] 

ASF GitHub Bot commented on PHOENIX-6937:
-----------------------------------------

stoty commented on PR #101:
URL: 
https://github.com/apache/phoenix-connectors/pull/101#issuecomment-1545499146

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   3m 45s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  4s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 
32 new or modified test files.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |  15m  0s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  18m 16s |  master passed  |
   | +1 :green_heart: |  compile  |   3m 12s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   2m  9s |  master passed  |
   | +1 :green_heart: |  javadoc  |   6m  5s |  master passed  |
   | -1 :x: |  scaladoc  |   0m 33s |  phoenix-hive-base in master failed.  |
   | -1 :x: |  scaladoc  |   0m 32s |  phoenix-flume-base in master failed.  |
   | -1 :x: |  scaladoc  |   0m 48s |  root in master failed.  |
   | +0 :ok: |  spotbugs  |   1m 38s |  phoenix-hive-base in master has 46 
extant spotbugs warnings.  |
   | +0 :ok: |  spotbugs  |   1m  6s |  phoenix-flume-base in master has 9 
extant spotbugs warnings.  |
   | +0 :ok: |  spotbugs  |   1m  2s |  phoenix-kafka-base in master has 3 
extant spotbugs warnings.  |
   | +0 :ok: |  spotbugs  |   2m 13s |  phoenix-spark-base in master has 40 
extant spotbugs warnings.  |
   | +0 :ok: |  spotbugs  |   4m  1s |  root in master has 112 extant spotbugs 
warnings.  |
   | +0 :ok: |  spotbugs  |   0m 43s |  phoenix5-spark3 in master has 22 extant 
spotbugs warnings.  |
   | +0 :ok: |  spotbugs  |   0m 41s |  phoenix-hive-base/phoenix4-hive in 
master has 46 extant spotbugs warnings.  |
   | +0 :ok: |  spotbugs  |   0m 53s |  phoenix-hive-base/phoenix5-hive in 
master has 45 extant spotbugs warnings.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 19s |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |  12m 40s |  root in the patch failed.  |
   | +1 :green_heart: |  compile  |   1m 51s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 51s |  the patch passed  |
   | +1 :green_heart: |  scalac  |   1m 51s |  the patch passed  |
   | -1 :x: |  checkstyle  |   2m  2s |  root: The patch generated 57 new + 
3729 unchanged - 316 fixed = 3786 total (was 4045)  |
   | +1 :green_heart: |  markdownlint  |   0m  1s |  There were no new 
markdownlint issues.  |
   | -1 :x: |  whitespace  |   0m  1s |  The patch has 190 line(s) that end in 
whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer 
https://git-scm.com/docs/git-apply  |
   | -1 :x: |  whitespace  |   0m  1s |  The patch 1006 line(s) with tabs.  |
   | -1 :x: |  xml  |   0m 24s |  The patch has 2 ill-formed XML file(s).  |
   | -1 :x: |  javadoc  |   0m 15s |  phoenix5-hive generated 3 new + 0 
unchanged - 0 fixed = 3 total (was 0)  |
   | -1 :x: |  javadoc  |   0m 13s |  phoenix5-spark generated 5 new + 0 
unchanged - 0 fixed = 5 total (was 0)  |
   | -1 :x: |  javadoc  |   0m 32s |  root generated 8 new + 5 unchanged - 16 
fixed = 13 total (was 21)  |
   | -1 :x: |  scaladoc  |   0m 39s |  phoenix5-hive in the patch failed.  |
   | -1 :x: |  scaladoc  |   0m 31s |  phoenix5-flume in the patch failed.  |
   | -1 :x: |  scaladoc  |   0m 34s |  phoenix5-spark generated 5 new + 0 
unchanged - 0 fixed = 5 total (was 0)  |
   | -1 :x: |  scaladoc  |   0m 44s |  root in the patch failed.  |
   | +1 :green_heart: |  spotbugs  |   0m 40s |  
phoenix-connectors-phoenix5-compat in the patch passed.  |
   | +1 :green_heart: |  spotbugs  |   1m  4s |  phoenix5-hive in the patch 
passed.  |
   | +1 :green_heart: |  spotbugs  |   0m 50s |  phoenix5-flume in the patch 
passed.  |
   | +1 :green_heart: |  spotbugs  |   0m 45s |  phoenix5-kafka in the patch 
passed.  |
   | +1 :green_heart: |  spotbugs  |   1m 12s |  phoenix5-spark in the patch 
passed.  |
   | +1 :green_heart: |  spotbugs  |   1m  9s |  phoenix5-spark3 in the patch 
passed.  |
   | +1 :green_heart: |  spotbugs  |   2m 43s |  root generated 0 new + 111 
unchanged - 1 fixed = 111 total (was 112)  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |  44m  6s |  root in the patch failed.  |
   | -1 :x: |  asflicense  |   1m 33s |  The patch generated 3 ASF License 
warnings.  |
   |  |   | 159m  7s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | XML | Parsing Error(s): |
   |   | phoenix5-spark/src/it/resources/log4j.xml |
   |   | phoenix5-spark/src/test/resources/log4j.xml |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.42 ServerAPI=1.42 base: 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-101/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/phoenix-connectors/pull/101 |
   | Optional Tests | dupname asflicense javac javadoc unit xml compile 
spotbugs hbaseanti checkstyle markdownlint scalac scaladoc |
   | uname | Linux 1f6a3524d942 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 
19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-connectors-personality.sh |
   | git revision | master / bcc3819 |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | scaladoc | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-101/1/artifact/yetus-general-check/output/branch-scaladoc-phoenix-hive-base.txt
 |
   | scaladoc | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-101/1/artifact/yetus-general-check/output/branch-scaladoc-phoenix-flume-base.txt
 |
   | scaladoc | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-101/1/artifact/yetus-general-check/output/branch-scaladoc-root.txt
 |
   | mvninstall | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-101/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-101/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt
 |
   | whitespace | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-101/1/artifact/yetus-general-check/output/whitespace-eol.txt
 |
   | whitespace | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-101/1/artifact/yetus-general-check/output/whitespace-tabs.txt
 |
   | xml | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-101/1/artifact/yetus-general-check/output/xml.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-101/1/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix5-hive.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-101/1/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix5-spark.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-101/1/artifact/yetus-general-check/output/diff-javadoc-javadoc-root.txt
 |
   | scaladoc | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-101/1/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-hive.txt
 |
   | scaladoc | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-101/1/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-flume.txt
 |
   | scaladoc | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-101/1/artifact/yetus-general-check/output/diff-scaladoc-scaladoc-phoenix5-spark.txt
 |
   | scaladoc | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-101/1/artifact/yetus-general-check/output/patch-scaladoc-root.txt
 |
   | unit | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-101/1/artifact/yetus-general-check/output/patch-unit-root.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-101/1/testReport/
 |
   | asflicense | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-101/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
 |
   | Max. process+thread count | 1926 (vs. ulimit of 30000) |
   | modules | C: phoenix-connectors-phoenix5-compat phoenix5-hive 
phoenix5-hive-shaded phoenix5-flume phoenix5-kafka phoenix5-spark 
phoenix5-spark-shaded phoenix5-spark3 phoenix5-spark3-it phoenix5-spark3-shaded 
phoenix5-connectors-assembly . U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-101/1/console
 |
   | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 markdownlint=0.22.0 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Remove the connectors for Phoenix 4.x
> -------------------------------------
>
>                 Key: PHOENIX-6937
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6937
>             Project: Phoenix
>          Issue Type: Task
>          Components: connectors
>            Reporter: Richárd Antal
>            Assignee: Richárd Antal
>            Priority: Major
>
> Phoenix 4.x is EOL, adding connectors for it complicates the project 
> structure, build time, etc.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to