Divneet18 commented on code in PR #1717: URL: https://github.com/apache/phoenix/pull/1717#discussion_r1365974852
########## phoenix-core/src/it/java/org/apache/phoenix/end2end/MutationBatchFailedStateMetricWithAllUpsertIT.java: ########## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.phoenix.end2end; + +import static org.apache.phoenix.monitoring.MetricType.DELETE_BATCH_FAILED_SIZE; +import static org.apache.phoenix.monitoring.MetricType.UPSERT_BATCH_FAILED_SIZE; +import static org.apache.phoenix.monitoring.MetricType.MUTATION_BATCH_FAILED_SIZE; +import static org.apache.phoenix.util.TestUtil.TEST_PROPERTIES; +import static org.apache.phoenix.monitoring.GlobalClientMetrics.GLOBAL_MUTATION_BATCH_FAILED_COUNT; + + +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.PreparedStatement; +import java.sql.SQLException; +import java.sql.Statement; +import java.util.Arrays; +import java.util.Collection; +import java.util.Map; +import java.util.Properties; + +import org.apache.phoenix.end2end.index.ImmutableIndexIT; +import org.apache.phoenix.hbase.index.Indexer; +import org.apache.phoenix.jdbc.PhoenixConnection; +import org.apache.phoenix.monitoring.MetricType; +import org.apache.phoenix.query.QueryServices; +import org.apache.phoenix.thirdparty.com.google.common.collect.Maps; +import org.apache.phoenix.util.PropertiesUtil; +import org.apache.phoenix.util.ReadOnlyProps; +import org.apache.phoenix.util.TestUtil; +import org.junit.Assert; +import org.junit.BeforeClass; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; + + +@Category(NeedsOwnMiniClusterTest.class) +@RunWith(Parameterized.class) +public class MutationBatchFailedStateMetricWithAllUpsertIT extends ParallelStatsDisabledIT { + String create_table = + "CREATE TABLE IF NOT EXISTS %s(ID VARCHAR NOT NULL PRIMARY KEY, VAL1 INTEGER, VAL2 INTEGER)"; + String indexName = generateUniqueName(); + String create_index = "CREATE INDEX " + indexName + " ON %s(VAL1 DESC) INCLUDE (VAL2)"; + String upsertStatement = "UPSERT INTO %s VALUES(?, ?, ?)"; + String deleteTableName = generateUniqueName(); + private final boolean transactional; + private String transactionProvider; Review Comment: The reason the tests are in three different classes is because we are testing for global metrics. every time a test is run and for every parameter the global metric always gets added on to the previous value rather than reseting to 0 (like mutation metrics does). Hence the actual answers for the metrics were different than expected and would change based on the way tests are run and sometimes the order too. To avoid that, we came up with making different ITs. However, I will make a superclass to avoid the recurring lines of code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
