[
https://issues.apache.org/jira/browse/PHOENIX-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780480#comment-17780480
]
ASF GitHub Bot commented on PHOENIX-7038:
-----------------------------------------
mihir6692 commented on PR #1682:
URL: https://github.com/apache/phoenix/pull/1682#issuecomment-1783251091
> My main concern is this is too sfdc focused. A conection profile doesn't
exist within the concept space of phoenix. I'd rebrand this as ConnectionInfo
metrics.
That's right. I have changed it to ConnecitonQueryService Metrics since this
metrics are calculated at CQS Level.
> My second concern is there apears to be a bunch of copy pasted or similar
code... I opened a Jira for a better overall metrics infrastrucutre and while
that is out of scope is it possiblegenericfy some of this.
That's right there are multiple class/code blocks which are copy pasted. I
will add notes of these
[PHOENIX-6174](https://issues.apache.org/jira/browse/PHOENIX-6174) to simplify
in future.
@dbwong
> Implement Connection Query Service Metrics
> ------------------------------------------
>
> Key: PHOENIX-7038
> URL: https://issues.apache.org/jira/browse/PHOENIX-7038
> Project: Phoenix
> Issue Type: New Feature
> Reporter: Mihir Monani
> Assignee: Mihir Monani
> Priority: Major
>
> With JDBC connection profile string, Clients can provide connection profile
> name. With use of Connection Profile, different kinds of clients/use-case in
> single JVM can create connection with different configuration like time-outs,
> retries, sleep between retries.
> Connection URL Example : jdbc:phoenix:localhost:2181:CONN_PROFILE_2
> Here CONN_PROFILE_2 is connection profile name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
