tkhurana commented on code in PR #1712:
URL: https://github.com/apache/phoenix/pull/1712#discussion_r1399874551
##########
phoenix-core/src/main/java/org/apache/phoenix/compile/ProjectionCompiler.java:
##########
@@ -677,21 +742,25 @@ private static class SelectClauseVisitor extends
ExpressionCompiler {
*/
private boolean isCaseSensitive;
private int elementCount;
- private List<KeyValueColumnExpression> arrayKVRefs;
- private List<Expression> arrayKVFuncs;
- private List<Expression> arrayOldFuncs;
- private List<ProjectedColumnExpression> arrayProjectedColumnRefs;
- private Map<Expression, Integer> arrayExpressionCounts;
- private SelectStatement statement;
-
- private SelectClauseVisitor(StatementContext context, GroupBy groupBy,
- List<KeyValueColumnExpression> arrayKVRefs, List<Expression>
arrayKVFuncs, Map<Expression, Integer> arrayExpressionCounts,
List<ProjectedColumnExpression> arrayProjectedColumnRefs, List<Expression>
arrayOldFuncs, SelectStatement statement) {
+ private List<KeyValueColumnExpression> serverParsedKVRefs;
+ private List<Expression> serverParsedKVFuncs;
+ private List<Expression> serverParsedOldFuncs;
+ private List<ProjectedColumnExpression>
serverParsedProjectedColumnRefs;
+ private Map<Expression, Integer> serverParsedExpressionCounts;
+ private SelectStatement statement;
+
+ private SelectClauseVisitor(StatementContext context, GroupBy groupBy,
+ List<KeyValueColumnExpression> serverParsedKVRefs,
+ List<Expression> serverParsedKVFuncs,
+ Map<Expression, Integer> serverParsedExpressionCounts,
+ List<ProjectedColumnExpression>
serverParsedProjectedColumnRefs,
+ List<Expression> serverParsedOldFuncs, SelectStatement
statement) {
super(context, groupBy);
- this.arrayKVRefs = arrayKVRefs;
- this.arrayKVFuncs = arrayKVFuncs;
- this.arrayOldFuncs = arrayOldFuncs;
- this.arrayExpressionCounts = arrayExpressionCounts;
- this.arrayProjectedColumnRefs = arrayProjectedColumnRefs;
+ this.serverParsedKVRefs = serverParsedKVRefs;
Review Comment:
can you add some comments here to explain what all these variables store
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
