tkhurana commented on code in PR #1712:
URL: https://github.com/apache/phoenix/pull/1712#discussion_r1399888652
##########
phoenix-core/src/main/java/org/apache/phoenix/compile/ProjectionCompiler.java:
##########
@@ -641,19 +702,23 @@ public <T> T accept(ExpressionVisitor<T> visitor) {
return null;
}
}
- private static void
serailizeArrayIndexInformationAndSetInScan(StatementContext context,
List<Expression> arrayKVFuncs,
- List<KeyValueColumnExpression> arrayKVRefs) {
+
+ private static void serializeServerParsedExpressionInformationAndSetInScan(
+ StatementContext context, String serverParsedExpressionAttribute,
+ List<Expression> serverParsedKVFuncs,
+ List<KeyValueColumnExpression> serverParsedKVRefs) {
ByteArrayOutputStream stream = new ByteArrayOutputStream();
try {
DataOutputStream output = new DataOutputStream(stream);
- // Write the arrayKVRef size followed by the keyvalues that needs
to be of type arrayindex function
- WritableUtils.writeVInt(output, arrayKVRefs.size());
- for (Expression expression : arrayKVRefs) {
+ // Write the arrayKVRef size followed by the keyvalues that needs
to be of
+ // type arrayindex+json function
+ WritableUtils.writeVInt(output, serverParsedKVRefs.size());
+ for (Expression expression : serverParsedKVRefs) {
expression.write(output);
}
- // then write the number of arrayindex functions followeed by the
expression itself
- WritableUtils.writeVInt(output, arrayKVFuncs.size());
- for (Expression expression : arrayKVFuncs) {
+ // then write the number of arrayindex+json functions followed by
the expression itself
Review Comment:
Again `+` here seems to imply that everything is serialized together
##########
phoenix-core/src/main/java/org/apache/phoenix/compile/ProjectionCompiler.java:
##########
@@ -641,19 +702,23 @@ public <T> T accept(ExpressionVisitor<T> visitor) {
return null;
}
}
- private static void
serailizeArrayIndexInformationAndSetInScan(StatementContext context,
List<Expression> arrayKVFuncs,
- List<KeyValueColumnExpression> arrayKVRefs) {
+
+ private static void serializeServerParsedExpressionInformationAndSetInScan(
+ StatementContext context, String serverParsedExpressionAttribute,
+ List<Expression> serverParsedKVFuncs,
+ List<KeyValueColumnExpression> serverParsedKVRefs) {
ByteArrayOutputStream stream = new ByteArrayOutputStream();
try {
DataOutputStream output = new DataOutputStream(stream);
- // Write the arrayKVRef size followed by the keyvalues that needs
to be of type arrayindex function
- WritableUtils.writeVInt(output, arrayKVRefs.size());
- for (Expression expression : arrayKVRefs) {
+ // Write the arrayKVRef size followed by the keyvalues that needs
to be of
+ // type arrayindex+json function
+ WritableUtils.writeVInt(output, serverParsedKVRefs.size());
+ for (Expression expression : serverParsedKVRefs) {
expression.write(output);
}
- // then write the number of arrayindex functions followeed by the
expression itself
- WritableUtils.writeVInt(output, arrayKVFuncs.size());
- for (Expression expression : arrayKVFuncs) {
+ // then write the number of arrayindex+json functions followed by
the expression itself
Review Comment:
Again `+` here seems to imply that everything is serialized together under a
single attribute
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
