[ 
https://issues.apache.org/jira/browse/PHOENIX-7122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789012#comment-17789012
 ] 

ASF GitHub Bot commented on PHOENIX-7122:
-----------------------------------------

stoty commented on PR #117:
URL: 
https://github.com/apache/phoenix-connectors/pull/117#issuecomment-1823924414

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m  9s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |  10m 35s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   8m 39s |  master passed  |
   | +1 :green_heart: |  compile  |   1m 12s |  master passed  |
   | +1 :green_heart: |  javadoc  |   0m 34s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | -1 :x: |  mvninstall  |   0m  9s |  root in master failed.  |
   | +0 :ok: |  mvndep  |   1m 18s |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   0m  5s |  root in the patch failed.  |
   | -1 :x: |  compile  |   0m  5s |  root in the patch failed.  |
   | -1 :x: |  javac  |   0m  5s |  root in the patch failed.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  xml  |   0m  2s |  The patch has no ill-formed XML 
file.  |
   | -1 :x: |  javadoc  |   0m  7s |  phoenix5-hive in the patch failed.  |
   | -1 :x: |  javadoc  |   0m  5s |  root in the patch failed.  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   0m  4s |  root in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 16s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  23m 30s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-117/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/phoenix-connectors/pull/117 |
   | Optional Tests | dupname asflicense javac javadoc unit xml compile |
   | uname | Linux 2014f9d92795 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 
15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-connectors-personality.sh |
   | git revision | master / 26c1aba |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | mvninstall | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-117/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt
 |
   | mvninstall | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-117/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
 |
   | compile | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-117/1/artifact/yetus-general-check/output/patch-compile-root.txt
 |
   | javac | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-117/1/artifact/yetus-general-check/output/patch-compile-root.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-117/1/artifact/yetus-general-check/output/patch-javadoc-phoenix5-hive.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-117/1/artifact/yetus-general-check/output/patch-javadoc-root.txt
 |
   | unit | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-117/1/artifact/yetus-general-check/output/patch-unit-root.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-117/1/testReport/
 |
   | Max. process+thread count | 93 (vs. ulimit of 30000) |
   | modules | C: phoenix5-hive . U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-117/1/console
 |
   | versions | git=2.7.4 maven=3.3.9 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Build connectors with Hbase 2.4
> -------------------------------
>
>                 Key: PHOENIX-7122
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-7122
>             Project: Phoenix
>          Issue Type: Improvement
>          Components: connectors
>            Reporter: Istvan Toth
>            Priority: Major
>
> This only affects client side code, which is supposed to be wire compatible 
> with any 2.x HBase server.
> We could also consider using 2.5, but 2.4 is the current stable version.
> This also requires updating the other related dependency versions.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to