shahrs87 commented on code in PR #1748:
URL: https://github.com/apache/phoenix/pull/1748#discussion_r1421816745


##########
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java:
##########
@@ -604,6 +608,8 @@ public static PName newPName(byte[] keyBuffer, int 
keyOffset, int keyLength) {
 
     private MetricsMetadataSource metricsSource;
     private long metadataCacheInvalidationTimeoutMs;
+    private Connection invalidateMetadataCacheConnection = null;

Review Comment:
   After making this change 
[here](https://github.com/apache/phoenix/pull/1748/commits/e3307b1529611788f1d5a4e2cee0b9fa1fabc39c),
 there are few test failures in: 
   1. 
`BackwardCompatibilityIT.testSelectUpsertWithNewClientWithMaxLookBackAge#org.apache.phoenix:phoenix-client-hbase-2.4:5.1.0`
   2. org.apache.phoenix.end2end.LoadSystemTableSnapshotIT#testPhoenixUpgrade
   See the failing jenkins job 
[here](https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1748/4/).
 
   From the jenkins logs, I am not able to root cause the failure.  @jpisaac  
Can you please help here? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to