shahrs87 commented on code in PR #1748: URL: https://github.com/apache/phoenix/pull/1748#discussion_r1434278977
########## phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java: ########## @@ -3546,9 +3586,6 @@ public Void call() throws Exception { success = true; return null; } - nSequenceSaltBuckets = ConnectionQueryServicesImpl.this.props.getInt( Review Comment: Moving initialization of nSequenceSaltBuckets to the constructor since SKIP_SYSTEM_TABLES_EXISTENCE_CHECK can be set to true and we return early at L3587 and this will leave nSequenceSaltBuckets initiliazed to default value i.e 0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org