[ 
https://issues.apache.org/jira/browse/PHOENIX-7195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814926#comment-17814926
 ] 

ASF GitHub Bot commented on PHOENIX-7195:
-----------------------------------------

stoty commented on PR #1817:
URL: https://github.com/apache/phoenix/pull/1817#issuecomment-1930479704

   We've already switched to log4j2 previously.
   I suspect that this was broken during the code refactor, when we forgot to 
re-add the log4j2 dependencies to phoenix-core.
   So that part is just a regression fix.
   
   Recent Hadoop releases has switched for lof4j1 to reload4j, and we haven't 
filtered that yet, so this is needed to restore the correct logging libraries 
(log4j2) in case a new Hadoop is used (otherwise we'd have both reload4j and 
log4j2 jars). This is a net new change.
   




> Exclude reload4j dependencies from Hadoop and add explicit log4j2 test 
> dependencies
> -----------------------------------------------------------------------------------
>
>                 Key: PHOENIX-7195
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-7195
>             Project: Phoenix
>          Issue Type: Bug
>          Components: core
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Blocker
>             Fix For: 5.2.0
>
>
> Hadoop 3.3.5 depends on reload4j.
> Add exlcudes for it, just like we do for log4j 1.
> Also, it seems that we do not explicitly add the log4j2 test dependencies to 
> phoenix-core, and only incidentally get them transitively via Omid.
> Add the explicit test dependencies.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to