stoty commented on code in PR #1808:
URL: https://github.com/apache/phoenix/pull/1808#discussion_r1488966585
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolIT.java:
##########
@@ -167,9 +167,9 @@ public static synchronized void setup(
//Maybe we're gonna have to refactor the namespace
if(clusterInitialized) {
tearDownMiniCluster(0);
- System.setProperty("java.io.tmpdir", tmpDir);
+ System.setProperty("java.io.tmpdir", tmpPath);
Review Comment:
and the old variable name reflects this better.
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolIT.java:
##########
@@ -167,9 +167,9 @@ public static synchronized void setup(
//Maybe we're gonna have to refactor the namespace
if(clusterInitialized) {
tearDownMiniCluster(0);
- System.setProperty("java.io.tmpdir", tmpDir);
+ System.setProperty("java.io.tmpdir", tmpPath);
Review Comment:
The old variable name is better here.
This is not used a base for paths, it's only used for saving the value of
the system property.
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/ParameterizedIndexUpgradeToolIT.java:
##########
@@ -115,7 +114,7 @@ public class ParameterizedIndexUpgradeToolIT extends
BaseTest {
@BeforeClass
public static synchronized void saveTmp () throws Exception {
- tmpDir = System.getProperty("java.io.tmpdir");
+ tmpPath = System.getProperty("java.io.tmpdir");
Review Comment:
nit: I find it better to use tmpDir here, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
