stoty commented on code in PR #1808:
URL: https://github.com/apache/phoenix/pull/1808#discussion_r1503646346
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/ParameterizedIndexUpgradeToolIT.java:
##########
@@ -115,7 +114,7 @@ public class ParameterizedIndexUpgradeToolIT extends
BaseTest {
@BeforeClass
public static synchronized void saveTmp () throws Exception {
- tmpDir = System.getProperty("java.io.tmpdir");
+ tmpPath = System.getProperty("java.io.tmpdir");
Review Comment:
See the comment above.
the tmpdir values originally set, and re-set by minicluster must be kept
separate.
Using the same tmpPath name we use elsewhere for constructing the test paths
for saving the value leads to misunderstanding and errors like the one above.
You could keep the tmpDir name here, or use something like originalTmpDir.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
