tkhurana commented on code in PR #1832:
URL: https://github.com/apache/phoenix/pull/1832#discussion_r1501296077
##########
phoenix-core-client/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java:
##########
@@ -941,12 +940,7 @@ private ScansWithRegionLocations getParallelScans(byte[]
startKey, byte[] stopKe
Scan scanFromContext = context.getScan();
if (scanRanges.getPointLookupCount() == 1) {
// leverage bloom filter for single key point lookup by
turning scan to Get Scan#isGetScan()
- try {
- scanFromContext = new Scan(context.getScan());
- } catch (IOException e) {
- throw new PhoenixIOException(e);
- }
- scanFromContext.withStopRow(scanFromContext.getStartRow(),
scanFromContext.includeStartRow());
+ scanFromContext.withStopRow(scanFromContext.getStartRow(),
true);
Review Comment:
You generate a scan in StatementContext and then we generate the actual
scans when we are creating the iterators like a high level scan in
statementcontext could generate multiple parallel scans one for each region
server. That is why I was copying the original scan stored in StatementContext.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
