[ 
https://issues.apache.org/jira/browse/PHOENIX-7237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821571#comment-17821571
 ] 

ASF GitHub Bot commented on PHOENIX-7237:
-----------------------------------------

ddupg commented on PR #1835:
URL: https://github.com/apache/phoenix/pull/1835#issuecomment-1968517106

   > I don't like this, as this is very brittle, and we will have the same 
problem again soon. (The previous patch has the same problem)
   > 
   > The real problem is that pherf seems to try to load its test config from 
anywhere on the classpath.
   > 
   > I would prefer that the logic in getResourcesPath is fixed so that it does 
not recursively search the whole classpath.
   > 
   > 
https://github.com/apache/phoenix/blob/bc1e2e7bea40c7d03940748e8f1d9f6b23339867/phoenix-pherf/src/main/java/org/apache/phoenix/pherf/util/ResourceList.java#L103
   Thanks @stoty for reviewing and opinion, I'll try to fix it.
   




> Pherf unit tests PherfTest and ResourceTest are failing
> -------------------------------------------------------
>
>                 Key: PHOENIX-7237
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-7237
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 5.2.0, 5.1.3
>            Reporter: Sun Xin
>            Priority: Major
>
> I got same problem like PHOENIX-5776  in master and 5.1 branch.
> {code:java}
> org.apache.phoenix.pherf.exception.PherfException: Could not load resources: 
> /datamodel/alter_table_add.sql {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to