shahrs87 commented on code in PR #1838:
URL: https://github.com/apache/phoenix/pull/1838#discussion_r1506709112
##########
phoenix-core/src/test/java/org/apache/phoenix/jdbc/PhoenixTestDriver.java:
##########
@@ -92,7 +93,8 @@ public synchronized Connection connect(String url, Properties
info) throws SQLEx
public synchronized ConnectionQueryServices
getConnectionQueryServices(String url, Properties infoIn) throws SQLException {
checkClosed();
final Properties info = PropertiesUtil.deepCopy(infoIn);
- ConnectionInfo connInfo = ConnectionInfo.create(url, null, info);
+ boolean isServerConnection =
Boolean.valueOf(info.getProperty(QueryUtil.IS_SERVER_CONNECTION));
+ ConnectionInfo connInfo = ConnectionInfo.create(url, null, info,
isServerConnection);
Review Comment:
Why do we want to pass as a separate argument for `isServerConnection`? It
is present in `info` object anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
