stoty commented on PR #139: URL: https://github.com/apache/phoenix-connectors/pull/139#issuecomment-2318441490
> When working on reviews I found out that AggregateIT and SaltedTableIT are running only pure phoenix tests and there is no tests for spark connector so I disabled them and I will open an issue to add real spark tests for these classes. That's not what I can see. Those tests are piped through Spark, and exercise the connector. Instead of executing directly, they are executed via Spark. Please check again, and if you still find that they are pure Phoenix tests, point out why the code to perform the queries via Spark does not work. (executeQuery() override ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
