stoty commented on code in PR #1978:
URL: https://github.com/apache/phoenix/pull/1978#discussion_r1760551403
##########
phoenix-core-client/src/main/java/org/apache/phoenix/compile/CreateIndexCompiler.java:
##########
@@ -161,13 +162,13 @@ private void verifyIndexWhere(ParseNode indexWhere,
StatementContext context,
column = dataTable.getColumns().get(i);
value = column.getViewConstant();
if (value == null) {
- stringBuilder.append(column.getName().getString() + ",");
Review Comment:
I'm pretty sure whe already have helper functions for this, let's not do
this manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]