haridsv commented on code in PR #1965:
URL: https://github.com/apache/phoenix/pull/1965#discussion_r1766179545
##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/CDCGlobalIndexRegionScanner.java:
##########
@@ -257,7 +252,7 @@ private Object getColumnValue(Cell cell, PDataType
dataType) {
private Object getColumnValue(byte[] cellValue, int offset, int length,
PDataType dataType) {
Object value;
- if (dataType.getSqlType() == Types.BINARY) {
+ if (CDCUtil.isBinaryType(dataType)) {
Review Comment:
This is just a utility method to abstract out the 3 types that we are
considering as binary type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
